fix: Merge IexecERC20Common & IexecERC20
#321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… IexecERC20 to include events directly
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/solidity-v8 #321 +/- ##
==================================================
Coverage 96.36% 96.36%
==================================================
Files 34 33 -1
Lines 1127 1127
Branches 227 213 -14
==================================================
Hits 1086 1086
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zguesmi
requested changes
Nov 7, 2025
… use abstract FacetBase
…aceNative to FacetBase and IexecERC20Facet to IexecERC20Base, while consolidating related interfaces
| new IexecCategoryManagerFacet__factory(), | ||
| new IexecConfigurationExtraFacet__factory(), | ||
| new IexecConfigurationFacet__factory(iexecLibOrders), | ||
| new IexecERC20Facet__factory(), |
Contributor
There was a problem hiding this comment.
add a todo : unplug this facet from proxy = 0xB0152eC6f48E64a92B66D4736aFA1b02d8D45169#code
Contributor
Author
There was a problem hiding this comment.
Fix Commit: bc392fb
I created the future migration script
gfournierPro
approved these changes
Nov 12, 2025
… in Solidity documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.